make type_flags(ReError) & HAS_ERROR
#122749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
aliemjay
commented
Mar 19, 2024
Comment on lines
-381
to
-440
| if let Err(guar) = arg.error_reported() { | ||
| return Err(guar); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is removed to avoid an ICE in tests/ui/type-alias-impl-trait/under-binder.rs. I'll rewrite it anyway in #116891.
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
region-err
branch
from
64a5ca5
to
cb4b2d1
Compare
| @@ -9,6 +9,19 @@ help: indicate the anonymous lifetime | |||
| LL | impl Trait for Ref<'_> {} | |||
| | ++++ | |||
|
|
|||
| error: aborting due to 1 previous error | |||
| error[E0277]: the trait bound `Ref<'_>: Trait` is not satisfied | |||
There was a problem hiding this comment.
Do you know why this error occurs?
compiler-errors
approved these changes
Mar 20, 2024
| @@ -10,6 +10,14 @@ note: lifetime declared here | |||
| LL | pub type Foo = impl for<'a> Trait<'a, Assoc = impl Test<'a>>; | |||
| | ^^ | |||
|
|
|||
| error: aborting due to 1 previous error | |||
| error: unconstrained opaque type | |||
There was a problem hiding this comment.
And this one too, do you know why it occurs?
There was a problem hiding this comment.
We don't register opaques that reference errors: https://github.com/rust-lang/rust/blame/a128516cf9de352ae1f9d430ed730363c7ca3c0c/compiler/rustc_infer/src/infer/opaque_types/mod.rs#L97.
I changed it in a later commit to register hidden types unconditionally.
rust-cloud-vms
bot
force-pushed
the
region-err
branch
from
cb4b2d1
to
d42e39f
Compare
rust-cloud-vms
bot
force-pushed
the
region-err
branch
from
d42e39f
to
0dc006b
Compare
aliemjay
changed the title
type_flags(ReError) | HAS_ERRORtype_flags(ReError) & HAS_ERROR
compiler-errors
approved these changes
Mar 20, 2024
|
Cool, I like this consistency fix @bors r+ rollup (only affects error code) |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 20, 2024
…rors make `type_flags(ReError) & HAS_ERROR` Self-explanatory. `TypeVisitableExt::references_error(ReError)` incorrectly returned `false`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#122545 (Ignore paths from expansion in `unused_qualifications`) - rust-lang#122644 (pattern analysis: add a custom test harness) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122729 (Relax SeqCst ordering in standard library.) - rust-lang#122740 (use more accurate terminology) - rust-lang#122749 (make `type_flags(ReError) & HAS_ERROR`) - rust-lang#122764 (coverage: Remove incorrect assertions from counter allocation) - rust-lang#122765 (Add `usize::MAX` arg tests for Vec) - rust-lang#122776 (Rename `hir::Let` into `hir::LetExpr`) - rust-lang#122786 (compiletest: Introduce `remove_and_create_dir_all()` helper) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#122545 (Ignore paths from expansion in `unused_qualifications`) - rust-lang#122729 (Relax SeqCst ordering in standard library.) - rust-lang#122740 (use more accurate terminology) - rust-lang#122749 (make `type_flags(ReError) & HAS_ERROR`) - rust-lang#122764 (coverage: Remove incorrect assertions from counter allocation) - rust-lang#122765 (Add `usize::MAX` arg tests for Vec) - rust-lang#122776 (Rename `hir::Let` into `hir::LetExpr`) - rust-lang#122786 (compiletest: Introduce `remove_and_create_dir_all()` helper) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
Rollup merge of rust-lang#122749 - aliemjay:region-err, r=compiler-errors make `type_flags(ReError) & HAS_ERROR` Self-explanatory. `TypeVisitableExt::references_error(ReError)` incorrectly returned `false`.
1 task
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 22, 2024
add 2 more tests for issues fixed by rust-lang#122749 Fixes rust-lang#121807 Fixes rust-lang#122098
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#121881 (std::net: adding acceptfilter feature for netbsd/freebsd.) - rust-lang#122817 (Doc Guarantee: BTree(Set|Map): `IntoIter` Iterate in Sorted by key Order) - rust-lang#122826 (Add tests for shortcomings of associated type bounds) - rust-lang#122829 (Implement `FusedIterator` for `gen` block) - rust-lang#122831 (make failure logs less verbose) - rust-lang#122837 (add test for rust-lang#122549) - rust-lang#122838 (Avoid noop rewrite of issues.txt) - rust-lang#122841 (add 2 more tests for issues fixed by rust-lang#122749) - rust-lang#122843 (Add a never type option to make diverging blocks `()`) - rust-lang#122844 (add test for ice "cannot relate region: LUB(ReErased, ReError)") - rust-lang#122845 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
Rollup merge of rust-lang#122841 - matthiaskrgr:moretests, r=wesleywiser add 2 more tests for issues fixed by rust-lang#122749 Fixes rust-lang#121807 Fixes rust-lang#122098
This was referenced Mar 22, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory.
TypeVisitableExt::references_error(ReError)incorrectly returnedfalse.